stripe / stripe-go / 2736
80%
master: 66%

LAST BUILD BRANCH: latest-codegen-beta
DEFAULT BRANCH: master
Ran
Jobs 4
Files 85
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2736

push

travis-ci

brandur 
Add `FormatURLPath` helper to allow safer URL path building

Adds a helper to the top-level package called `FormatURLPath`. It's
basically a pass-through to `Sprintf`, except that it only takes string
parameters. This is designed to make invocations slightly more safe --
we've had a little trouble in the past where a string pointer was
accidentally passed instead of a string, and because `Sprintf` doesn't
automatically dereference or anything, the result is an invalid URL.

It also gives us the opportunity to call `url.QueryEscape` on every
parameter for a little additional safety. Previously, this was being
invoked manually only in certain packages like `plan`.

I changed all uses of `%v` in invocations to `%s` for consistency and
because we won't need any types beyond strings. In the same spirit, I
also changed all the places that we were concatenating strings (like
`"/skus/"+id`) to invoke `FormatURLPath`.

This patch is fairly noisy, but you can mostly just examine the added
function in `stripe.go` and test in `stripe_test.go`:

``` go
func FormatURLPath(format string, params ...string) string {
    // Parameters must be converted to interface{} before we send them to
    // Sprintf.
    untypedParams := make([]interface{}, len(params))
    for i, param := range params {
	    untypedParams[i] = interface{}(url.QueryEscape(param))
    }

    return fmt.Sprintf(format, untypedParams...)
}
```

3677 of 4708 relevant lines covered (78.1%)

98.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2736.1 85
78.1
 Travis Job 2736.1
2 2736.2 85
78.1
 Travis Job 2736.2
4 2736.4 85
78.1
 Travis Job 2736.4
5 2736.5 85
78.1
 Travis Job 2736.5
Source Files on build 2736