2592
63%

Ran 04 Jun 2018 08:25PM UTC

Jobs 3

Files 15

Run time 4min

Badge

Embed ▾

pending completion

Build # 2592

Build Type

push

travis-ci

Committed by

Ichimonji10

Commit Message

Simplify api.Client hostname warning

An `api.Client` object should only be used to communicate with one host.
Its value proposition is that it trades off some flexibility for
convenience: when repeatedly communicating with a single host, certain
options and behaviours can be repeatedly sent with little effort.

If an `api.Client` object is used to communicate with some other host, a
warning is raised. Unfortunately, the logic used to generate this
warning is baroque. It goes like this:

1. Take `self.pulp_host`, a `PulpHost` object, and build a base URL by
   passing it to a URL building method on `self._cfg`, a
   `PulpSmashConfig` object.
2. Parse this URL, and extract the hostname.
3. Compare the extracted hostname to the hostname of the host a request
   is being made to.

This logic is correct, but it's unnecessarily convoluted. Simplify it.
Do the following instead: Compare the hostname of `self.pulp_host`
against the hostname of the host a request is being made to.

Run Details

699 of 1090 relevant lines covered (64.13%)

1.92 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2592.1	04 Jun 2018 08:27PM UTC	64.13	Travis Job 2592.1
2	2592.2	04 Jun 2018 08:25PM UTC	64.13	Travis Job 2592.2
3	2592.3	04 Jun 2018 08:26PM UTC	64.13	Travis Job 2592.3

Source Files on build 2592

Detailed source file information is not available for this build.

PulpQE / pulp-smash / 2592
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2592

PulpQE / pulp-smash / 2592 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2592

PulpQE / pulp-smash / 2592
63%

README BADGES
x