mit-dci / lit / 444

11%

push

travis-ci

Fix race condition in channel push code (#167)

* Fix bug where non-witness outputs were selected in PickUtxos

If there were a mixture of witness and non-witness outputs in the db then PickUtxos would sometimes select non-witness inputs even when only-witness was set. This prevented channel funding in a number of cases.

* Don't pass LitNode by-value to message handlers

In Go, passing a mutex by value copies it and creates a new mutex. Thus if you pass a containing struct by-value and lock the mutex, you're locking a copy rather than the original

* Don't build the justice tx in a coroutine, could be a race condition

* Missed merge conflicts

* Use consts.MinOutput

14 of 14 new or added lines in 2 files covered. (100.0%)

1440 of 13525 relevant lines covered (10.65%)

595.32 hits per line