13
88%

Ran 04 Jun 2018 03:20PM UTC

Jobs 1

Files 13

Run time 1s

Badge

Embed ▾

pending completion

Build # 13

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Remove Sites framework dependency (#9) (#15)

This merge does two things:

    1. Removes completely dependency on the Sites framework (which was implemented erroneously).
    Specifically, site field on Attribute and related constraints. With those changes, attributes are now global. That is, all attributes are visible to all entities. As a result, slug in now unique.

    2. Content-type field is used to limit entities that can be assigned an attribute (see get_all_attributes method on Entity). This way attributes with content_type assigned are, for all intended purposes, private to Entity of that content type. The problem is that those attributes are still visible to other entities. Moreover, originally, attributes had non-unique slugs that are unique together with content_type and site. With removal of site (and because content_type is nullable) a situation might exist in which two attributes exist with the same slug/name but one with content_type and one with NULL. Simple solution to all this hassle is to drop private attributes altogether, which is what this pull-request does.

Resolves: #9

Commits:
* Remove sites dependency; fix Attribute uniqueness (#9)
* Add uniqueness test to attributes
* Remove content_type from Attribute class
* Update runtests
* Remove redudant  call
* Fix wrong assertion in attribute test
* Fix string formatting

Run Details

430 of 550 relevant lines covered (78.18%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	13.1	04 Jun 2018 03:20PM UTC	0	78.18	Travis Job 13.1

Source Files on build 13

Detailed source file information is not available for this build.

makimo / django-eav2 / 13
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13

makimo / django-eav2 / 13 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13

makimo / django-eav2 / 13
88%

README BADGES
x