3218
78%

Ran 01 Jun 2018 06:01PM UTC

Jobs 1

Files 101

Run time 3min

Badge

Embed ▾

pending completion

Build # 3218

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix the usage of `google.datalab.utils.Iterator`. (#688)

The Iterator class takes a `retriever` method to which it passes
two arguments. Until now, the various `retriever` methods passed
in have interpreted the second argument differently; some treat
it as a page size, while others rely on it representing the total
number of items iterated over so far.

This change fixes the inconsitency by making every implementation
treat the second argument as the number of items retrieved so far.

For implementations that were relying on that value being the
page size, they have been updated to calculate the page size themselves
the same way that it would have been calculated by the previous
version of the Iterator class.

This fixes #686

Run Details

5444 of 6993 relevant lines covered (77.85%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	3218.4 (TOX_ENV=coveralls)	01 Jun 2018 06:01PM UTC	0	77.85	Travis Job 3218.4

Source Files on build 3218

Detailed source file information is not available for this build.

googledatalab / pydatalab / 3218
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3218

googledatalab / pydatalab / 3218 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3218

googledatalab / pydatalab / 3218
78%

README BADGES
x