IFCA / caso / 106

51%

push

travis-ci

<a href="https://github.com/IFCA/caso/commit/<a class=hub.com/IFCA/caso/commit/2161a33b84a39afb4ebe28113f4f50e055dc92c0">2161a33b8<a href="https://github.com/IFCA/caso/commit/2161a33b84a39afb4ebe28113f4f50e055dc92c0">&quot;&gt;Fix record extraction and do not request only deleted records

Commit </a><a class="double-link" href="https://github.com/IFCA/caso/commit/<a class="double-link" href="https://github.com/IFCA/caso/commit/0058b6cf239f29c8ae7f41212a66dcf9c14f7435">0058b6cf2</a>">0058b6cf2</a><a href="https://github.com/IFCA/caso/commit/2161a33b84a39afb4ebe28113f4f50e055dc92c0"> introduced a bug in how
we retrieve the records, since we introduced the &quot;deleted&quot; filter and
this was filtering out all the instances that are not deleted.

Moreover, the way we were retrieving the results was wrong as only
servers with a changed status within the requested period were
considered for the record building.

We cannot use &#39;changes-since&#39; in the servers.list() API query, as it
will only include changes that have chanted its status after that date.
Also, we cannot just get all the usages and then query the servers.get()
server by server, as deleted servers are not returned by ths
servers.get() call. What we do now is the following.

    1.- List all the deleted servers that changed after the start date
    2.- Build the records for the period [start, end]
    3.- Get all the usages
    4.- Iter over the usages and:
    4.1.- get information for non deleted servers
    4.2.- do nothing with deleted servers, as we collected in in step (2)

However, usage was eventually correctly reported, as sooner or later one
server may have a changed status and we will generate the record.

In order to get accurate results, accounting records must be regenerated
at sites, possibly month by month, like:

    caso-extract  --extract-from 2017-01-01 --extract-to 2017-01-31
    caso-extract  --extract-from 2017-02-01 --extract-to 2017-02-28
    (...)

Closes IFCA/caso#47

39 of 145 branches covered (26.9%)

295 of 575 relevant lines covered (51.3%)

0.51 hits per line