osteele / liquid / 140

49%

Pull #30

travis-ci

Returning proper error type causes less panics during expression eval.

When user-defined function is called, it does convert all the arguments using
MustConvert, which panics on error with an error. However 'func (e expression)
Evaluate(ctx Context)' from sub package "expressions" catches those panics and
converts some of them to errors. Raw errors returned from strconv functions
are "repanicked", but proper error types such as values.TypeError are not.
Hence we should use it here.

59 of 59 new or added lines in 1 file covered. (100.0%)

2663 of 2986 relevant lines covered (89.18%)

647.21 hits per line