wikimedia / PyBal / 284

97%

push

travis-ci

<a href="https://github.com/wikimedia/PyBal/commit/acdd0ebf7">Implement common base class for &quot;looping check&quot; monitors

Many monitors (but not all) check their realservers by doing a
looping call at a semi-fixed interval. Rather than implementing
and testing this separately for each monitor, move this functionality
to a common base class, LoopingCheckMonitoringProtocol.

Instead of DelayedCall / reactor.callLater, use a LoopingCall.
This removes the need for each check to make sure to set up a new
call. The main concern previously was that this could result in
multiple checks running at the same time if a check is slow, but
this is taken care of if checks return a Deferred.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/PyBal/commit/4ab40dfb7">4ab40dfb7</a>

123 of 123 new or added lines in 10 files covered. (100.0%)

6000 of 6349 relevant lines covered (94.5%)

0.95 hits per line