370
97%

Ran 29 May 2018 08:36AM UTC

Jobs 9

Files 27

Run time 2min

Badge

Embed ▾

pending completion

Build # 370

Build Type

Pull #107

travis-ci

Committed by

web-flow

Commit Message

Remove redundant line in models.py

The line is

```python
qs = model_class.all_objects.filter(**lookup_kwargs)
```

It was present just before the check for `all_objects`

```
if hasattr(model_class, 'all_objects'):
```

So this check was useless. But instead of removing the check, I guess the intention was to have it and the duplicated line is a rest of a previous refactoring

Pull Request Pull Request #107: Remove redundant line in models.py

Run Details

804 of 822 relevant lines covered (97.81%)

8.74 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	100.0	0.0%	safedelete/tests/test_admin.py
1	90.0	0.0%	safedelete/admin.py
1	90.91	0.0%	safedelete/tests/urls.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	370.1 (DJANGO_VERSION="stable/1.11.x")	29 May 2018 08:36AM UTC	27	97.45	Travis Job 370.1
2	370.2 (DJANGO_VERSION="stable/1.11.x")	29 May 2018 08:36AM UTC	27	97.2	Travis Job 370.2
3	370.3 (DJANGO_VERSION="stable/1.11.x")	29 May 2018 08:36AM UTC	27	97.2	Travis Job 370.3
4	370.4 (DJANGO_VERSION="stable/1.11.x")	29 May 2018 08:36AM UTC	27	97.2	Travis Job 370.4
5	370.5 (DJANGO_VERSION="stable/2.0.x")	29 May 2018 08:36AM UTC	27	96.96	Travis Job 370.5
6	370.6 (DJANGO_VERSION="stable/2.0.x")	29 May 2018 08:38AM UTC	27	96.96	Travis Job 370.6
7	370.7 (DJANGO_VERSION="stable/2.0.x")	29 May 2018 08:38AM UTC	27	96.96	Travis Job 370.7
8	370.8 (DJANGO_VERSION="stable/2.1.x")	29 May 2018 08:38AM UTC	27	97.08	Travis Job 370.8
9	370.9 (DJANGO_VERSION="stable/2.1.x")	29 May 2018 08:38AM UTC	27	97.08	Travis Job 370.9

makinacorpus / django-safedelete / 370
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 370

makinacorpus / django-safedelete / 370 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 370

makinacorpus / django-safedelete / 370
97%

README BADGES
x