m-lab / ndt-e2e-clientworker / 243

87%

cron

travis-ci

Changes to get Ubuntu 16.04 and OSX 10.12.3 working. (#94)

* Bumps selenium for Python to the lastest stable version (3.0.2).

* Adds naming support for Ubuntu 16.04 and OSX 10.12.

* Makes sure that version has a value, else it moves on to browserVersion (Firefox now apparently uses browserVersion, but has a blank version element).

* Requires the latest version of selenium, currently 3.3.1.

* Implements a dumb wait of 10s if browser is Safari 10, since checking for elem visibility is apparently broken in that browser.

* Comments out page load timeout setting, since it breaks Firefox on Win10 and apparently the chromedriver ignores it.

* Adds same element visibility hack as was done to browser_client_common.py.

* Sets sleep time for Safari 10 to passed value of 'timeout' rather than a fixed number.

* Bumps UI wait timeout from 2 to 10, since 2 doesn't seem to be enough for Safari 10 to fully load everything.

* Creates a global variable with the Safari 10 version number, and references that in the code instead of the specific number.

* Uses object attributes that are guaranteed to exists and have a value.

* Adds an additional newline for proper code style.

* Uses a real object instead of a string for mock_driver, since function being tested now actually expects an object with certain attributes set.

18 of 18 new or added lines in 4 files covered. (100.0%)

592 of 680 relevant lines covered (87.06%)

0.87 hits per line