5862
77%

Ran 25 May 2018 08:13PM UTC

Jobs 1

Files 410

Run time 238min

Badge

Embed ▾

pending completion

Build # 5862

Build Type

push

travis-ci

Committed by

pervazea

Commit Message

Performance fixes: move all stats_mode checks to end of transaction (#1381)

* Removed all incremental stats updates from TimestampOrderingTransactionManager. Now processed entirely in TransactionManager's EndTransaction().

* Minor refactor on stats_type variable.

* Added more comments to EndTransaction()

* Adjust logic to find database oid in EndTransaction, also remove redundant code from Commit and Abort in TOTM.

* Removed stats_mode check from BeginTransaction(). This requires us to rely on the transaction timestamp to calculate the latency stat during EndTransaction(). Loss in precision looks reasonable for stats purposes:

transaction latency (new timestamp mode): 52.366000
transaction latency (old stats mode): 52.379732

Also moved all stats-related tasks from EndTransaction() to a dedicated function.

* clang-format-3.6 on modified lines.

Run Details

43 of 43 new or added lines in 1 file covered. (100.0%)

24884 of 32151 relevant lines covered (77.4%)

79699.71 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
8	85.61	0.0%	src/concurrency/transaction_manager.cpp

Uncovered Existing Lines

Lines	Coverage	∆	File
2	90.73	-1.32%	src/codegen/util/oa_hash_table.cpp
8	85.61	0.0%	src/concurrency/transaction_manager.cpp
8	89.74	0.0%	src/executor/seq_scan_executor.cpp
8	75.39	-4.19%	src/gc/transaction_level_gc_manager.cpp
15	75.79	-0.5%	src/concurrency/transaction_context.cpp
24	72.93	0.0%	src/executor/hybrid_scan_executor.cpp
32	90.16	-0.24%	src/concurrency/timestamp_ordering_transaction_manager.cpp
44	74.47	0.0%	src/executor/index_scan_executor.cpp
72	79.1	0.0%	src/storage/data_table.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
2	5862.2 (NAME="gcc5 Debug/Tests/AddressSanitizer/Coveralls" CXX=g++-5 CC=gcc-5 PELOTON_BUILD_TYPE=Debug COVERALLS=On)	25 May 2018 08:13PM UTC	820	77.4	Travis Job 5862.2

cmu-db / peloton / 5862
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 5862

cmu-db / peloton / 5862 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 5862

cmu-db / peloton / 5862
77%

README BADGES
x