107
44%
master: 66%

Ran 25 May 2018 05:45PM UTC

Jobs 1

Files 19

Run time 3min

Badge

Embed ▾

pending completion

Build # 107

Build Type

push

travis-ci

Committed by

mewmew

Commit Message

meta: fix issue with errors.WithStack, io.Copy expect io.EOF

We cannot use errors.WithStack [1] to maintain call stack information
of zeros.Read as this method is invoked from io.Copy (in verifyPadding)
which expects io.EOF.

Note, the type of the returned error in the case of EOF becomes,
"errors.withStack" with the concrete value:
	errors.withStack{error: io.EOF, stack: callers()}

This broke the tests:

https://travis-ci.org/mewkiz/flac/builds/383805346#L540

We cannot update the standard library to check for io.EOF
using errors.Cause(err) == io.EOF. Thus, this seems like the
only solution.

Unfortunate, and a bit scare, as there may be other use of
interfaces which break since the error returned is wrapped
with added context.

Hope this gets resolved in Go 2. I know @bradfitz among others
have raised their interest in finding ways to improve and further
simplify error handling mechanisms [2].

[1]: https://github.com/pkg/errors
[2]: https://github.com/golang/go/wiki/Go2

Updates #22.

Related to golang/go#21161.

Run Details

1131 of 1787 relevant lines covered (63.29%)

194946.62 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	107.1	25 May 2018 05:45PM UTC	0	63.29	Travis Job 107.1

Source Files on build 107

Detailed source file information is not available for this build.

mewkiz / flac / 107
44%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 107

mewkiz / flac / 107 44% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 107

mewkiz / flac / 107
44%
master: 66%

README BADGES
x