GoogleCloudPlatform / httplib2shim / 39

56%

push

travis-ci

Handle conn objects with port=None and App Engine Standard HTTPS (#12)

* Handle conn.port=None

Conditional to prevent the string 'None' from being included in
URLs when the port property of the conn object is None.

* Cater for HTTPS connections from App Engine Standard

Without this extra conditional, requests from App Engine Standard
applications will always be HTTP.

* Extracted method to construct URI

There is quite a bit of conditional logic involved in constructing
the full URI from the connection object. This commit extracts this
to a separate class method and adds a number of unit tests for
coverage.

* Fix lint issues

51 of 87 branches covered (58.62%)

54 of 54 new or added lines in 2 files covered. (100.0%)

660 of 1182 relevant lines covered (55.84%)

0.56 hits per line