samvera / browse-everything / 858

99%

master: 99%

push

travis-ci

<a href="https://github.com/samvera/browse-everything/commit/<a class=hub.com/samvera/browse-everything/commit/<a class="double-link" href="https://git"><a class=hub.com/samvera/browse-everything/commit/babddf03c4a2ee28d242ccc6596884039b5b8921">babddf03c<a href="https://github.com/samvera/browse-everything/commit/babddf03c4a2ee28d242ccc6596884039b5b8921">&lt;a href=&quot;https://github.com/samvera/browse-everything/commit/babddf03c4a2ee28d242ccc6596884039b5b8921&quot;&gt;&quot;&gt;s3 driver includes file_name in link_for extras

Some client code expects this, such as [sufia](https://github.com/samvera/sufia/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/samvera/browse-everything/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/samvera/browse-everything/commit/63e3f1338fb409b7854491ab3c9467209e009aa6&quot;&gt;63e3f1338&lt;/a&gt;&quot;&gt;63e3f1338&lt;/a&gt;&lt;a href=&quot;https://github.com/samvera/browse-everything/commit/babddf03c4a2ee28d242ccc6596884039b5b8921&quot;&gt;/app/assets/javascripts/sufia/browse_everything.js) and (identical) [hyrax](https://github.com/samvera/hyrax/blob/0fe39d4f4dcc24deb805c1e66527ac^C9df7741a/app/assets/javascripts/hyrax/browse_everything.js).

In sufia/hyrax if the filename isn&#39;t there, it ends up blank in the UI.

I also added the expires header (where applicable), because I noticed that the [box driver](https://github.com/samvera/browse-everything/blob/</a><a class="double-link" href="https://github.com/samvera/browse-everything/commit/<a class="double-link" href="https://github.com/samvera/browse-everything/commit/2c0a3447049f7ee925a0ee0759d246fa28c474ac">2c0a34470</a>">2c0a34470</a><a href="https://github.com/samvera/browse-everything/commit/babddf03c4a2ee28d242ccc6596884039b5b8921">/lib/browse_everything/driver/box.rb#L59) has it, so I figured it couldn&#39;t hurt, although I am not aware of client code using it.

The sufia/hyrax client code REALLY wants a `size` key as well, but there doesn&#39;t seem to be a way to get it in the current architecture without another S3 API call. The size was already there displayed in the listing, so it's already been fetched, and there ought to be a way for the client code to get it... but I can't figure out what it is, so punting on that for now.

558 of 562 relevant lines covered (99.29%)

99.51 hits per line