google / openhtf / 1892

43%

master: 62%

Build Type

push

travis-ci

Committed by Kenneth Schiller

Commit Message

OpenHTF: Guess mimetype from attachment name.

Rationale: In attach_from_file() we try to guess mimetype from the source filename. It has sometimes surprised users that the mimetype is not inferred from the attachment name as well.

TESTED=
Before: `complete_test_output.txt` gets `type: BINARY` (integer=5)
e.g. https://www.mfg-inspector.com/pr/chauffeur/testrun/chauffeur/QQABTkEAAQYBY0GFCrI=.raw
After: `complete_test_output.txt` gets `type: TEXT_UTF8` (integer=7)
e.g. https://www.mfg-inspector.com/pr/chauffeur/testrun/chauffeur/QQABTkEAAQYBY0arU1Q=.raw

The attachment `complete_test_output.txt` is attached using `test.attach_from_file(open_file.name, 'complete_test_output.txt')`. (In this case, open_file.name is something like `/tmp/asdfljk` and has no extension.)
https://cs.corp.google.com/piper///depot/google3/third_party/car/hw/testing/framework/logs.py?rcl=195879010&l=125

PiperOrigin-RevId: 196022999

Run Details

454 of 454 new or added lines in 3 files covered. (100.0%)

2377 of 5535 relevant lines covered (42.94%)

0.43 hits per line