ericblade / mws-advanced / 144

88%

master: 88%

push

travis-ci

begin separation of parsers from fetch logic

- add lib/parsers/marketplaceData, which is called by getMarketplaces to
  perform the parsing work.
- this allows for separate testing of parsers from fetchers, allowing...
- add test/mock/ListMarketplaceParticipations.json, which is used by...
- new test section "Parsers". The first one reads the mock data provided in
  this commit, and feeds it to lib/parsers/marketplaceData, testing it in
  exactly the same way that the live API is tested.
- with some additional cleanup and effort, it should be possible to get
  mocked data from MWS's PHP code, or saved via live calls (make sure you
  sanitize any sensitive information from it), and provide it either via
  file system reads, or a mocked MWS server.
- this commit also makes first official use of the "parseEndpoint" function
  which returns a function that calls callEndpoint, then calls the provided
  argument function with the return from callEndpoint.  This looks like:
  parseEndpoint('MwsApiName')(parserFunction)
- I'm going to admit that I'm not 100% positive that there is good use for
  this to return a function, only that it felt like there was a really good
  reason as to why I might want it to do it like that for future expansion.

182 of 226 branches covered (80.53%)

Branch coverage included in aggregate %.

453 of 532 relevant lines covered (85.15%)

181.72 hits per line