puppetlabs / pdk / 1637

93%

master: 92%

push

travis-ci

Change Metadata.from_file to reliably raise

When no `metadata.json` exists, `File.file?` can throw nasty exceptions:
```
david@davids:~/git/pdk$ ./bin/pdk bundle list
Traceback (most recent call last):
	11: from ./bin/pdk:29:in `<main>'
	10: from ./bin/pdk:29:in `load'
	 9: from /home/david/git/pdk/exe/pdk:6:in `<top (required)>'
	 8: from /home/david/git/pdk/lib/pdk/cli.rb:18:in `run'
	 7: from /home/david/gems/ruby/2.5.0/gems/cri-2.10.1/lib/cri/command.rb:287:in `run'
	 6: from /home/david/gems/ruby/2.5.0/gems/cri-2.10.1/lib/cri/command.rb:269:in `run'
	 5: from /home/david/gems/ruby/2.5.0/gems/cri-2.10.1/lib/cri/command.rb:329:in `run_this'
	 4: from /home/david/git/pdk/lib/pdk/cli/bundle.rb:24:in `block (2 levels) in <module:CLI>'
	 3: from /home/david/git/pdk/lib/pdk/cli/util.rb:96:in `puppet_from_opts_or_env'
	 2: from /home/david/git/pdk/lib/pdk/util/puppet_version.rb:86:in `from_module_metadata'
	 1: from /home/david/git/pdk/lib/pdk/module/metadata.rb:48:in `from_file'
/home/david/git/pdk/lib/pdk/module/metadata.rb:48:in `file?': no implicit conversion of nil into String (TypeError)
david@davids:~/git/pdk$ 
```

1 of 1 new or added line in 1 file covered. (100.0%)

2575 of 2773 relevant lines covered (92.86%)

12.63 hits per line