ESMCI / manage_externals / 170

86%

push

travis-ci

Merge pull request #103 from billsacks/no_logging

Make no-logging be the default

@jedwards4b, @gold2718 and I all feel that no-logging should be the
default. This change is made here. I introduced a new --logging option
that can be used to turn on logging. I have maintained --no-logging as
an option for backwards compatibility - e.g., since cime calls
checkout_externals with '--no-logging' - but now --no-logging doesn't
actually do anything.

User interface changes?: Yes
`--no-logging` is now the default, new `--logging option` to turn on
logging.  I have kept `--no-logging` in place to ensure backwards
compatibility.

Fixes: #95 (Should not write to log file when running status command)
As noted in #97, @jedwards4b, @gold2718 and I felt that logging should
always be off by default.

Testing:
  test removed: none
  unit tests: pass
  system tests: pass
  manual testing: Ran with `--logging`, `--no-logging`, both and
    neither, with python2 and python3 (note that running with both
    generates an error message)

366 of 424 branches covered (86.32%)

Branch coverage included in aggregate %.

1090 of 1178 relevant lines covered (92.53%)

3.68 hits per line