• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stripe / stripe-ruby / 2334
94%
master: 97%

Build:
Build:
LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Ran 07 May 2018 09:52PM UTC
Jobs 3
Files 60
Run time 49s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2334

push

travis-ci

brandur
Merge query parameters coming from path with `params` argument

If specifying both query parameters in a path/URL down to Faraday (e.g.,
`/v1/invoices/upcoming?coupon=25OFF`) _and_ query parameters in a hash
(e.g., `{ customer: "cus_123" }`), it will silently overwrite the ones
in the path with the ones in the hash. This can cause problems where
some critical parameters are discarded and causes an error, as seen in
issue #646.

This patch modifies `#execute_request` so that before going out to
Faraday we check whether the incoming path has query parameters. If it
does, we decode them and add them to our `query_params` hash so that
all parameters from either place are preserved.

Fixes #646.

5 of 5 new or added lines in 1 file covered. (100.0%)

1480 of 1580 relevant lines covered (93.67%)

1028.92 hits per line

Jobs
ID Job ID Ran Files Coverage
3 2334.3 (2.2) 07 May 2018 09:52PM UTC 0
93.67
Travis Job 2334.3
4 2334.4 (2.3.0) 07 May 2018 09:52PM UTC 0
93.65
Travis Job 2334.4
5 2334.5 (2.4.0) 07 May 2018 09:53PM UTC 0
93.67
Travis Job 2334.5
Source Files on build 2334
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2334
  • 3a2724bf on github
  • Prev Build on brandur-merge-query-params (#2332)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc