2330
94%
master: 97%

Ran 07 May 2018 09:34PM UTC

Jobs 3

Files 60

Run time 24s

Badge

Embed ▾

pending completion

Build # 2330

Build Type

push

travis-ci

Committed by

brandur

Commit Message

Merge query parameters coming from path with `params` argument

If specifying both query parameters in a path/URL down to Faraday (e.g.,
`/v1/invoices/upcoming?coupon=25OFF`) _and_ query parameters in a hash
(e.g., `{ customer: "cus_123" }`), it will silently overwrite the ones
in the path with the ones in the hash. This can cause problems where
some critical parameters are discarded and causes an error, as seen in
issue #646.

This patch modifies `#execute_request` so that before going out to
Faraday we check whether the incoming path has query parameters. If it
does, we decode them and add them to our `query_params` hash so that
all parameters from either place are preserved.

Fixes #646.

Run Details

1480 of 1580 relevant lines covered (93.67%)

1028.66 hits per line

Jobs

ID	Job ID	Ran	Coverage
3	2330.3 (2.2)	07 May 2018 09:34PM UTC	93.67	Travis Job 2330.3
4	2330.4 (2.3.0)	07 May 2018 09:34PM UTC	93.65	Travis Job 2330.4
5	2330.5 (2.4.0)	07 May 2018 09:34PM UTC	93.67	Travis Job 2330.5

Source Files on build 2330

Detailed source file information is not available for this build.

stripe / stripe-ruby / 2330
94%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2330

stripe / stripe-ruby / 2330 94% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2330

stripe / stripe-ruby / 2330
94%
master: 97%

README BADGES
x