1897
55%

Ran 04 May 2018 12:06AM UTC

Jobs 2

Files 86

Run time 3min

Badge

Embed ▾

pending completion

Build # 1897

Build Type

Pull #1009

travis-ci

Committed by

web-flow

Commit Message

Rework test http client to handle external redirects.

...and document the requirement that HTTPClient implementations must
follow redirects.

Previously, I was getting a test failure for WIP obmd related tests,
because the client wasn't following a redirect from power_off. Simply
telling the flask test client to follow redirects is insufficient, since
it can't make requests except to the flask app, so the connection to
obmd fails.

However, we also can't just use a regular RequestsHTTPClient, because
that will attempt to make an actual network connection in all cases, and
we aren't actually listening on a socket.

This patch replaces FlaskHTTPClient with a client for testing which uses
either Flask's test client, or the requests library, as appropriate.

Pull Request Pull Request #1009: Rework test http client to handle external redirects.

Run Details

2070 of 3850 relevant lines covered (53.77%)

0.54 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1897.1 (DB=sqlite)	04 May 2018 12:06AM UTC	86	53.77	Travis Job 1897.1
2	1897.2 (DB=postgres SPOOF_MANUAL_MIGRATIONS=true)	04 May 2018 12:09AM UTC	55	0.0	Travis Job 1897.2

CCI-MOC / hil / 1897
55%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1897

CCI-MOC / hil / 1897 55%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1897

CCI-MOC / hil / 1897
55%

README BADGES
x