70
88%

Ran 03 May 2018 08:11PM UTC

Jobs 3

Files 2

Run time 1min

Badge

Embed ▾

pending completion

Build # 70

Build Type

push

travis-ci

Committed by

bluca

Commit Message

Problem: poller can segfault when modified from registered handler. (#219)

* Problem: poller can segfault when modified from registred handler.

It is possible that a user would like to add/remove sockets from
handlers. As handlers and poll items might be removed while not
being processed yet - we have a segfault situation.
Provided unit test `remove_from_handler` demonstrates the problem.

Solution: Modify internal poll item data structure only after processing
of events is finished.

Please not that events processing path performance remains the same when there are
no modification (add/remove) to the poller (no rebuild) - main real use case.

As an effect of changes `size()` method has been removed as it does not
represent any meaningful information anymore. There are active and pending
(waiting for rebuild) poll items so two different sizes. User can
easily track on their side number of registered sockets if original size
information is needed.

`wait` method returns number of processed sockets now. It might be
useful information to a user for no extra cost.

Run Details

36 of 64 relevant lines covered (56.25%)

16.44 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	70.1 (BUILD_TYPE=cmake ZMQ_VERSION=4.2.5)	03 May 2018 08:11PM UTC	56.25	Travis Job 70.1
2	70.2 (BUILD_TYPE=cmake ZMQ_VERSION=4.2.0)	03 May 2018 08:11PM UTC	56.25	Travis Job 70.2
3	70.3 (MATRIX_EVAL="CC=gcc-7 && CXX=g++-7" BUILD_TYPE=cmake ZMQ_VERSION=4.2.5 DRAFT=1)	03 May 2018 08:13PM UTC	64.38	Travis Job 70.3

Source Files on build 70

Detailed source file information is not available for this build.

zeromq / cppzmq / 70
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 70

zeromq / cppzmq / 70 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 70

zeromq / cppzmq / 70
88%

README BADGES
x