bitpay / bitcore-lib / 387

98%

Pull #238

travis-ci

Don't mutate the elliptic curve prototype with get* additions

Point's prototype is set to the prototype of ec('secp256k1').curve.point(), which means mutation to it is shared across users of 'elliptic' via the in-memory representation of those objects.

This is not generally a problem, for example, with `validate` it's a simple set, so the greatest risk is that it will be directly overwritten.

But in the case of `getX` and `getY`, both methods are overwritten with others that depend on the prior implementation as stored in `_get*`. If this happens twice, then the implementation of `_getX` is replaced with something that depends on a call to `_getX`, and the callers is stuck in an infinite loop.

2203 of 2343 branches covered (94.02%)

4 of 4 new or added lines in 1 file covered. (100.0%)

5022 of 5148 relevant lines covered (97.55%)

1963.42 hits per line