9091
66%

Ran 02 May 2018 05:43PM UTC

Jobs 1

Files 85

Run time 4s

Badge

Embed ▾

pending completion

Build # 9091

Build Type

push

travis-ci

Committed by

rolandshoemaker

Commit Message

SA: Cleanup, forbid nil issuer arg to AddCertificate (#3675)

In #3651 we introduced a new parameter to sa.AddCertificate to allow specifying the Issued date. If nil, we defaulted to the current time to maintain deployability guidelines.

Now that this has been deployed everywhere this PR updates SA.AddCertificate and the gRPC wrappers such that a nil issuer argument is rejected with an error.

Unit tests that were previously using nil for the issued time are updated to explicitly set the issued time to the fake clock's now().

Resolves #3657

Coverage Stats

10008 of 16030 relevant lines covered (62.43%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	9091.5 (RUN="coverage")	02 May 2018 05:43PM UTC	0	62.43	Travis Job 9091.5

Source Files on build 9091

Detailed source file information is not available for this build.

letsencrypt / boulder / 9091
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9091

letsencrypt / boulder / 9091 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9091

letsencrypt / boulder / 9091
66%

README BADGES
x