nats-io / node-nats / 567

89%

push

travis-ci

Node10 fixes (#223)

[FIX] #222 - socket upgrade used socket.end() which half closed the socket.
[FIX] Deprecations in node10 for new Buffer()
[FIX] fs.writeFile makes callback mandatory


- Changed Buffer.alloc() to Buffer.allocUnsafe() provides significant performance boost to clients that publish Buffers. It however requires that we bump sem version, as min compatible nodejs is 4.5+

```
1.0.0 (string)                3,524,850 msgs/sec
1.0.0                              1,785,395 msgs/sec
0.8.10 - new Buffer()   1,066,666 msgs/sec
```

356 of 395 branches covered (90.13%)

3 of 3 new or added lines in 1 file covered. (100.0%)

693 of 728 relevant lines covered (95.19%)

2409.37 hits per line