ably / ably-ruby / 828

98%

master: 98%

push

travis-ci

Log outcome of REST request retries

Example warnings emitted for a request that fails but then succeeds is now:

```
warn: Ably::Rest::Client - Retry 1 for get /time {} as initial attempt failed (seq #5g-tSQ): getaddrinfo: nodename nor servname provided, or not known (SocketError)
warn: Ably::Rest::Client - Request SUCCEEDED after 1 retry for get /time {} (seq #5g-tSQ, time elapsed 5.11s)
```

And a request that never succeeds:

```
warn: Ably::Rest::Client - Retry 1 for get /time {} as initial attempt failed (seq #KyefoA): getaddrinfo: nodename nor servname provided, or not known (SocketError)
warn: Ably::Rest::Client - Retry 2 for get /time {} as initial attempt failed (seq #KyefoA): getaddrinfo: nodename nor servname provided, or not known (SocketError)
error: Ably::Rest::Client - Request FAILED after 2 retries for get /time {} (seq #KyefoA, time elapsed 15.02s)
```

See related https://github.com/ably/docs/issues/359

39 of 39 new or added lines in 3 files covered. (100.0%)

16538 of 16796 relevant lines covered (98.46%)

26052.29 hits per line