GoogleCloudPlatform / cloud-debug-nodejs / 2018

93%

Pull #421

travis-ci

chore: update semver to `5.5.0`

The current `package.json` requires `semver@'^5.1.0'`.  However,
the `semver.coerce` function does not exist in that version.

As part of PR #407, `package-lock.json` was regenerated and
specified semver version 5.5.0 should be used.

When the tests were run, Node >= 8 would use package-lock.json
and installed semver 5.5.0 that has `semver.coerce`.

In addition, for Node < 8, the tests would install the latest
version of semver (5.5.0) that has `semver.coerce`.

As a result, the system and unit tests would all pass.

However, if user code, or the code of its dependencies, requires
only semver@'^5.1.0', and that version was installed prior to
installing @google-cloud/debug-agent, version `5.1.0` of semver
could be used.  However since this version doesn't have the
`semver.coerce` function, the debug agent would crash on
startup.  This is what happened in issue #420.

Fixes: #420

750 of 906 branches covered (82.78%)

1703 of 1837 relevant lines covered (92.71%)

8608.59 hits per line