794
98%

Ran 27 Apr 2018 03:06PM UTC

Jobs 10

Files 153

Run time 30min

Badge

Embed ▾

pending completion

Build # 794

Build Type

Pull #146

travis-ci

Committed by

web-flow

Commit Message

Remove legacy broken resume logic

This previously checked that a connection should only be resumed if it was connected within the last two minutes.  This is not correct, and we should rely on our connection freshness checks which we do.

See https://github.com/ably/ably-ruby/pull/146#discussion_r184624962

Pull Request Pull Request #146: Only resume if connection is fresh (RTN15g*)

Run Details

143 of 143 new or added lines in 5 files covered. (100.0%)

16456 of 16723 relevant lines covered (98.4%)

25293.59 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	94.12		spec/support/event_emitter_helper.rb
5	99.11	-0.63%	spec/acceptance/realtime/connection_failures_spec.rb

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.75	0.0%	spec/support/protocol_helper.rb
1	100.0	0.0%	spec/support/debug_failure_helper.rb
1	99.11	-0.63%	spec/acceptance/realtime/connection_failures_spec.rb
1	95.93	-0.36%	lib/ably/realtime/connection.rb
2	99.51	0.0%	spec/acceptance/rest/message_spec.rb
2	97.76	0.0%	spec/acceptance/realtime/presence_spec.rb
3	99.87	0.0%	spec/acceptance/rest/auth_spec.rb
4	98.47	0.0%	spec/acceptance/realtime/message_spec.rb
5	100.0	0.0%	spec/acceptance/rest/presence_spec.rb

Jobs

ID	Job ID	Ran	Files	Coverage
2	794.2 (2.0.0, RSPEC_RETRY=true PROTOCOL=json)	27 Apr 2018 03:06PM UTC	153	98.28	Travis Job 794.2
3	794.3 (2.1.10, RSPEC_RETRY=true PROTOCOL=json)	27 Apr 2018 03:09PM UTC	153	98.26	Travis Job 794.3
4	794.4 (2.2.0, RSPEC_RETRY=true PROTOCOL=json)	27 Apr 2018 03:09PM UTC	153	98.27	Travis Job 794.4
5	794.5 (2.3.6, RSPEC_RETRY=true PROTOCOL=json)	27 Apr 2018 03:16PM UTC	153	98.28	Travis Job 794.5
6	794.6 (2.4.1, RSPEC_RETRY=true PROTOCOL=json)	27 Apr 2018 03:21PM UTC	153	98.29	Travis Job 794.6
8	794.8 (2.0.0, RSPEC_RETRY=true PROTOCOL=msgpack)	27 Apr 2018 03:23PM UTC	153	98.3	Travis Job 794.8
9	794.9 (2.1.10, RSPEC_RETRY=true PROTOCOL=msgpack)	27 Apr 2018 03:24PM UTC	153	98.3	Travis Job 794.9
10	794.10 (2.2.0, RSPEC_RETRY=true PROTOCOL=msgpack)	27 Apr 2018 03:30PM UTC	153	98.29	Travis Job 794.10
11	794.11 (2.3.6, RSPEC_RETRY=true PROTOCOL=msgpack)	27 Apr 2018 03:35PM UTC	153	98.3	Travis Job 794.11
12	794.12 (2.4.1, RSPEC_RETRY=true PROTOCOL=msgpack)	27 Apr 2018 03:37PM UTC	153	98.3	Travis Job 794.12

Source Files on build 794

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ably / ably-ruby / 794
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 794

ably / ably-ruby / 794 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 794

ably / ably-ruby / 794
98%

README BADGES
x