ethereumjs / ethereumjs-vm / 1343

38%

Pull #295

travis-ci

Align Bloom Filter Hashing with Mainnet Compatible Clients

When clients like Go-ethereum and Parity create bloom filters, they
trim leading zeroes off the topic before applying keccak to hash the
value. As far as I can tell, this is inconsistent with the yellow paper
(see: https://github.com/ethereum/yellowpaper/issues/690), but for
ethereumjs-vm generated bloom filters to be compatible with tools that
consume mainnet bloom filters, it should follow the same pattern.

See https://github.com/ethereum/go-ethereum/blob/master/core/types/bloom9.go#L60
where go-ethereum casts topics as big.Int then back to bytes, effectively
stripping away leading zeroes before hashing.

504 of 674 branches covered (74.78%)

6 of 6 new or added lines in 1 file covered. (100.0%)

1462 of 1710 relevant lines covered (85.5%)

510658.76 hits per line