salesforce / refocus-collector / 185

94%

push

travis-ci

Part2 find samples and test cleanup (#131)

* Clean up logger.error and logger.info

* Export "heartbeat" instead of "sendHeartbeat"

* Export heartbeat listener directly instead of via "handleHeartbeatResponse" fn

* changeCollectorStatus - no-op if old and new status are the same

* doBulkUpsert cleanup - short-circuit and clean up some error handling

* clean up regex reference in schema

* clean up test commands

* Add httpUtils.findSubjects fn and tests.

* use findSamples and clean up tests

package.json
- improve readability with new "testcov" and "postcov" scripts (called from "test" script)
- add simple utility packages for safe set/get

src/heartbeat/heartbeat.js
- reuse httpUtils.doPost instead of setting up the request manually here

src/heartbeat/listener.js
- improve readability

src/heartbeat/utils.js
- when adding or updating a generator, add a "refocus" attribute to the generator, and set the refocus.url and refocus.proxy -- that way we don't have to deal with looking up in global config object from everywhere deep in the stack, which makes all testing much cleaner
- in setupRepeater fn, pass the functions through to createGeneratorRepeater (this makes testing easier)
- minor cleanup for readability, logging, debug
- added a FIXME comment to come back to after we deal with bulk=false
- adopt some of the new queue fns (updateSize, updateFlushTimeout, etc.)

src/remoteCollection/collect.js
- rename the old "collect" fn to "prepareRemoteRequest", then wrap that inside a new "collect" fn which *first* looks up the list of subjects from Refocus, *then* calls prepareRemoteRequest, which calls sendRemoteRequest

src/remoteCollection/handleCollectResponse.js
- added a FIXME comment to come back to after we deal with bulk=false
- pulled the individual sample validation out of the queue enqueue fn so doing it here first before enqueuing
- don't Promise.reject(...) anywhere if we're not handling the rejec... (continued)

227 of 257 branches covered (88.33%)

Branch coverage included in aggregate %.

584 of 598 relevant lines covered (97.66%)

147.87 hits per line