angular-ui / ui-grid / 4384

84%

push

travis-ci

fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER (#6690)

* fix(Grid.js): ScrollIfNecessary does not account for scrollWidth correctly

Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop.

fixes #6653

* Add check for gridCol not null

Make sure gridCol is not null before checking for enableCellEditOnFocus

* fix(Grid.js) Vertical scroll calculates height wrong with enableHorizontalScrollbar: NEVER

Use scrollbarHeight instead of scrollbarWidth for vertical scroll calculations. scrollbarHeight has the value 0 when enableHorizontalScrollbar is set to NEVER.

Round calculated boundary values as computed style may have decimal number which will not match pixelsToSeeRow

3104 of 4273 branches covered (72.64%)

4 of 4 new or added lines in 1 file covered. (100.0%)

6195 of 7331 relevant lines covered (84.5%)

590.83 hits per line