9026
66%

Ran 19 Apr 2018 05:45PM UTC

Jobs 1

Files 85

Run time 13s

Badge

Embed ▾

pending completion

Build # 9026

Build Type

push

travis-ci

Committed by

rolandshoemaker

Commit Message

orphan-finder: set cert issued date based on notbefore. (#3651)

The Boulder orphan-finder command uses the SA's AddCertificate RPC to add orphaned certificates it finds back to the DB. Prior to this commit this RPC always set the core.Certificate.Issued field to the
current time. For the orphan-finder case this meant that the Issued date would incorrectly be set to when the certificate was found, not when it was actually issued. This could cause cert-checker to alarm based on the unusual delta between the cert NotBefore and the core.Certificate.Issued value.

This PR updates the AddCertificate RPC to accept an optional issued timestamp in the request arguments. In the SA layer we address deployability concerns by setting a default value of the current time when none is explicitly provided. This matches the classic behaviour and will let an old RA communicate with a new SA.

This PR updates the orphan-finder to provide an explicit issued time to sa.AddCertificate. The explicit issued time is calculated using the found certificate's NotBefore and the configured backdate.
This lets the orphan-finder set the true issued time in the core.Certificate object, avoiding any cert-checker alarms.

Resolves #3624

Coverage Stats

9956 of 15954 relevant lines covered (62.4%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	9026.5 (RUN="coverage")	19 Apr 2018 05:45PM UTC	0	62.4	Travis Job 9026.5

Source Files on build 9026

Detailed source file information is not available for this build.

letsencrypt / boulder / 9026
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9026

letsencrypt / boulder / 9026 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9026

letsencrypt / boulder / 9026
66%

README BADGES
x