blond-admin / BLonD / 141

31%

push

travis-ci

Update for one-turn feedback and unittests (#120)

* Fixed bug in cavity_feedback.track() and speed-up in modulator()

In SPSOneTurnFeedback.llrf_model(), pi/2 is added to the phase of V_set
so that it is in the Q-channel. This pi/2 must be subtracted from
phi_corr in SPSCavityFeedback.track().
Improved computation time in signal_processing.modulator() by computing
sine and cosine only once.

* Replaced 'slices' by 'profile' in impedance.py

Also added print statement in init of ring.py to show that it's using my
version of the Clean-up branch

* Changed rf_params to rf_station

Changed rf_params to rf_station to better match variable names

* Updated benchmarks to be compadible with latest BLonD clean-up version

This mainly involves a change in the call to the ring constructor.

* Change to moving_average

Changed '!=' comparison to 'is not' to eliminate an error. Also changed
doc-string, since 'center' parameter does no longer exist.

* Removed code that was accidentally copied twice.

* Updated signal_processing and added unittests

- Changed moving_average since it computed moving average incorrectly.
E.g. the length of the returned array was wrong (off by one). Now it
returns the correct length, but code needs to be changed. Changed
Benchmark3 accordingly. !!! Need to also update the code for the OTFB
!!! Removed outdated unittests for moving_average, that depended on
options which no longer exist.
- Commented out function real_to_cartesian because it is not needed
anywhere, and gives error when maximum is negative
- Added more unittests

* Added unittests for wake field and beam loading in test_impulse_response

* Updated cavit_feedback and added unittests

Following the update of moving_average, llrf_model() has been updated to
take again the correct number of points from V_mov_av_prev. Also added
test_feedback.py

* Several changes to cavit_feedback.py

- renamed V_gen to dV_gen in LLRF part (... (continued)

276 of 276 new or added lines in 5 files covered. (100.0%)

1030 of 3113 relevant lines covered (33.09%)

0.33 hits per line