jaegertracing / jaeger-client-python / 638

95%

push

travis-ci

Remove support for non-ascii baggage keys; enable testing with Py 3.6  (#154)

* enable testing with Python 3.6
* some fixes to the codec to handle unicode strings with Py3
* a fix for thrift converter that broke Py3 compatibility in 3.8.0 release
* skip crossdock unit tests when on Py3
* remove tests for non-ascii characters in baggage keys - while those tests were passing with Py2, they didn't actually confirm that such baggage was readable on the receiving side, and it didn't really work. It's very hard to make it work because there's no way of knowing which encoding the strings are coming in from inbound request. This change **officially removes support for non-ascii characters in baggage keys.**

Signed-off-by: Yuri Shkuro <ys@uber.com>

366 of 400 branches covered (91.5%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

1530 of 1588 relevant lines covered (96.35%)

0.96 hits per line