gophercloud / gophercloud / 2030

79%

push

travis-ci

Blockstorage v3 quota-set support - part 1, Get (#877)

* Copy compute v2 quotaset to storage v3 quotaset.

Monkey see, monkey do.

* Modify tests and fixtures to use block storage values.

* Update QuotaSet and UpdateQuotaSet types for block storage.

* Fix test fixture values.

* Handle apparent bug in PartialPut test case.

* Group stimuli and their responses together in fixtures.

* Improve test fixture parmaeterization.

This allows us to more easily see problems with test cases by specifying
the expected inputs and outputs in the same place in code rather than
the implicit assumption that the fixture has the output expected for the
test case.

Another advantage is that this brings us that much closer to the ideal
of test fixtures consisting purely of a list of data structures which
can then be iterated over in a single test case function that glues all
the pieces together to validate that the tested code, given some input
data, produces the expected output data.

* Implement data-driven testing approach.

* Remove redundant test.

* Absorb TestGetDetail into DDT test cases.

* Absorb TestUpdate into DDT test cases.

* Absorb TestPartialUpdate into DDT test cases.

* Remove unnecessary field initialization.

* Get rid of defunct fixture function.

* Absorb TestDelete into DDT test cases.

* Not expecting a json response in Error test case.

* Fix blockstorage quotaset api docs.

* Fix blockstorage QuotaDetail struct.

* s/tenantID/projectID/

* Fix blockstorage quotaset detailed url.

* Accept HTTP 200 for blockstorage quotaset DELETE

* OS block storage quotasets don't support groups.

* Get rid of unused resourceURL.

* Add blockstorage quotaset GetDefaults function.

* Add quotaset acceptance tests.

* s/block storage/compute/ in comments.

* Fix blockstorage quotaset test json strings.

* Fix blockstorage quotaset Delete tests.

* Handle URI query params in blockstorage quot... (continued)

25 of 25 new or added lines in 3 files covered. (100.0%)

5610 of 7227 relevant lines covered (77.63%)

4.7 hits per line