283
88%

Ran 21 Dec 2014 01:58AM UTC

Jobs 2

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 283

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

stop LocalModule from creating a .peru dir by default

Summary:
Instead, only create the dir when we need to actually write a
`lastimports` file. This is a short term fix for our parser tests
inadvertently creating a `.peru` directory in our tests dir. With this
fix, D145 should be able to remove `.peru` from our `.gitignore` file.

In the long term, it's clear that we have an organization problem. The
parser should obviously not be calling code that writes to disk. I think
the best solution will be to tear up the LocalModule class. It's a
holdover from when we thought we would be doing much more complicated
things to override dirs, like applying imports and running build
commands. Going forward, override dirs are going to be a much simpler
concept, and we can probably separate the parser from the code that
deals with the local project dir in the process of simplifying it.

Tracking issue: https://github.com/buildinspace/peru/issues/72

Test Plan:
`arc patch D145`, remove `.peru` from `.gitignore`, clean the repo, and
run tests. Tests pass without any warning about dirty files.

Reviewers: sean

Reviewed By: sean

Differential Revision: https://phabricator.buildinspace.com/D146

Run Details

Jobs

ID	Job ID	Ran	Files	Coverage
1	283.1	21 Dec 2014 01:58AM UTC	0		Travis Job 283.1
2	283.2	21 Dec 2014 01:59AM UTC	0		Travis Job 283.2

Source Files on build 283

Detailed source file information is not available for this build.

buildinspace / peru / 283
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 283

buildinspace / peru / 283 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 283

buildinspace / peru / 283
88%

README BADGES
x