TryGhost / Ghost-Admin / 3633

70%

push

travis-ci

🐛 Fixed `j` and `k` keys not working in editor after visiting Tags screen (#1002)

closes https://github.com/TryGhost/Ghost/issues/9543
- https://github.com/TryGhost/Ghost-Admin/pull/972 moved `keymaster` from Bower to NPM but version 1.6.3 is not published to NPM and it contains fixes for unbinding multiple keys (eg, `'down, j': 'moveDown'`). Switched to fetching directly from github to ensure we have the latest version
- removed the "has registered shortcuts" guard added in https://github.com/TryGhost/Ghost-Admin/pull/976 - it was working around the buggy keymaster version but was also buggy itself because it meant shortcuts could only be registered the first time a route was loaded even though we unregister all of the shortcuts when leaving the route

1779 of 2817 branches covered (63.15%)

12 of 12 new or added lines in 1 file covered. (100.0%)

4116 of 5700 relevant lines covered (72.21%)

45.9 hits per line