8960
66%

Ran 06 Apr 2018 02:57PM UTC

Jobs 1

Files 85

Run time 8s

Badge

Embed ▾

pending completion

Build # 8960

Build Type

push

travis-ci

Committed by

rolandshoemaker

Commit Message

Improve nesting of RPC deadlines (#3619)

gRPC passes deadline information through the RPC boundary, but client and server have the same deadline. Ideally we'd like the server to have a slightly tighter deadline than the client, so if one of the server's onward RPCs or other network calls times out, the server can pass back more detailed information to the client, rather than the client timing out the server and losing the opportunity to log more detailed information about which component caused the timeout.

In this change, I subtract 100ms from the deadline on the server side of our interceptors, using our existing serverInterceptor. I also check that there is at least 100ms remaining in which to do useful work, so the server doesn't begin a potentially expensive task only to abort it.

Fixes #3608.

Coverage Stats

9895 of 15850 relevant lines covered (62.43%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
9	8960.9 (RUN="coverage")	06 Apr 2018 02:57PM UTC	0	62.43	Travis Job 8960.9

Source Files on build 8960

Detailed source file information is not available for this build.

letsencrypt / boulder / 8960
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8960

letsencrypt / boulder / 8960 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8960

letsencrypt / boulder / 8960
66%

README BADGES
x