329
95%

Ran 19 Dec 2014 12:55PM UTC

Jobs 9

Files 24

Run time 4min

Badge

Embed ▾

pending completion

Build # 329

Build Type

Pull #132

travis-ci

Committed by

stevehodgkiss

Commit Message

Fix conflict with ActiveSupport dependency loading

`Object#require` in ActiveSupport attempts to call their own `load_dependency` method [1], which is overridden in the Adapter class and causes an error when Lotus Model is used with Rails. This addresses the conflict by choosing a different method name.

```
/opt/boxen/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/model-17b037ea2cb5/lib/lotus/model/config/adapter.rb:85:in `load_dependency': wrong number of arguments (1 for 0) (ArgumentError)
        from /opt/boxen/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/activesupport-4.2.0.rc1/lib/active_support/dependencies.rb:274:in `require'
        from /opt/boxen/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/model-17b037ea2cb5/lib/lotus/model/config/adapter.rb:87:in `load_dependency'
```

[1] https://github.com/rails/rails/blob/4-2-0/activesupport/lib/active_support/dependencies.rb

Pull Request Pull Request #132: Fix conflict with ActiveSupport dependency loading

Run Details

861 of 869 relevant lines covered (99.08%)

792.44 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	329.1 (2.0.0)	19 Dec 2014 12:55PM UTC	99.03	Travis Job 329.1
2	329.2 (2.1.0)	19 Dec 2014 12:56PM UTC	99.03	Travis Job 329.2
3	329.3 (2.1.1)	19 Dec 2014 12:56PM UTC	99.03	Travis Job 329.3
4	329.4 (2.1.2)	19 Dec 2014 12:56PM UTC	99.03	Travis Job 329.4
5	329.5 (2.1.3)	19 Dec 2014 12:55PM UTC	99.03	Travis Job 329.5
6	329.6 (2.1.4)	19 Dec 2014 12:56PM UTC	99.03	Travis Job 329.6
7	329.7 (2.1.5)	19 Dec 2014 12:57PM UTC	99.03	Travis Job 329.7
8	329.8 (2.2.0)	19 Dec 2014 12:56PM UTC	99.03	Travis Job 329.8
9	329.9 (rbx-2)	19 Dec 2014 01:00PM UTC	99.3	Travis Job 329.9

Source Files on build 329

Detailed source file information is not available for this build.

lotus / model / 329
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 329

lotus / model / 329 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 329

lotus / model / 329
95%

README BADGES
x