gernest / mention / 26

98%

Pull #14

travis-ci

Always separate on spaces and unprintable characters

Some code is sending our backend mentions with a zero-width joiner for
whatever reason, for example:

    @example\u200d skldjg

The mention that would would get picked up is `@example\u200d`, instead
of the expected `@example`.

This patch always treats spaces and unprintable characters as
a terminator. I'm not sure if it ever makes sense to use a space inside
a mention?

Alternatively, I could add a callback function, or something?
Maintaining a list of all space/unprintable characters doesn't strike me
as a good idea, and the `unicode.Is*()` functions contain some
performance optimisations for the common (non-multibyte) use cases.

The downside is some performance loss:

master:

    BenchmarkGetTags-4       2000000               988 ns/op

this patch:

    BenchmarkGetTags-4       1000000              1259 ns/op

1 of 1 new or added line in 1 file covered. (100.0%)

42 of 45 relevant lines covered (93.33%)

155.22 hits per line