mperham / sidekiq / 1890
46%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 48
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1890

Pull #1943

travis-ci

aprescott 
Rely on perform_one for inline testing.

Inline testing currently overrides perform_async to simply directly call

    SomeJob.new.perform(*args)

after round-tripping *args through JSON serialization/deserialization
and setting up a fake worker.jid value.

After Sidekiq issue 1938, most (all?) other places now use execute_job
instead, which indirectly calls SomeJob.new.perform(*args).

testing.rb defines a perform_one which is one of the places where the
new execute_job method is used. It also takes care of setting
worker.jid.

This change replaces the inline testing mode from a direct
SomeJob.new.perform method call to instead:

    1. Place a job on the faked array queue, at the front of the list.
    2. Immediately call perform_one, to take the job off the front of
       the list.

This reduces the duplication around what it means to execute a job,
makes the usage of execute_job consistent across applications, and
improves inline testing's mirroring of how the job would actually be
run -- by "placing" it on a queue and then "pulling" the job off the
queue straight away.

As a bonus, any third-party gems which provide an implementation of
execute_job (such as in issue 1938) can test that their execute_job is
working by using perform_async with inline testing, instead of manually
calling perform_one in the fake testing mode or disabling Sidekiq
testing entirely.
Pull Request #1943: Rely on perform_one for inline testing

2076 of 2425 relevant lines covered (85.61%)

154.08 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1890.1 (jruby-19mode) 48
86.09
 Travis Job 1890.1
2 1890.2 (rbx-2) 46
94.02
 Travis Job 1890.2
3 1890.3 (2.0.0) 31
85.91
 Travis Job 1890.3
4 1890.4 (2.1) 31
85.81
 Travis Job 1890.4
5 1890.5 (2.2) 31
85.91
 Travis Job 1890.5
Source Files on build 1890
Coverage ∆ File Lines Relevant Covered Missed Hits/Line