zulip / zulip-mobile / 4873

65%

push

travis-ci

Fix: button is enabled just after typing `https://` or 'http://' in the realm input. (#2187)

* dependency: Use 'is-url' package instead of 'valid-url'.

`is-url` is in active development and cover more cases,
like 'https://' is valid url according to 'valid-url'
but invalid for 'is-url', which is correct.

As on commit data: last release of 'is-url' was 5 days ago,
for 'valid-url' it was 5 years ago.

* realmScreen: More robust logic to disable button.

Check whether realm url is valid or not with the
help of `isUrl` method, and disable if it is not valid.

Fix: button is enabled just after typing `https://`
or 'http://' in the realm input.

871 of 1938 branches covered (44.94%)

Branch coverage included in aggregate %.

1593 of 3234 relevant lines covered (49.26%)

28.32 hits per line