SOHU-Co / kafka-node / 740

89%

cron

travis-ci

Add missing super ctor calls across code base, fix small quirks (#899)

* Add missing super ctor calls across code base, fix small quirks

1) noAckBatchOptions in KafkaClient was not being read correctly from options
2) Use EventEmitter directly as name instead of events.EventEmitter so that IDE code completion behaves correctly
3) Fix some typos/case incorrectness
4) Raise Client max event listeners, as high volume publishing while a broker is not ready schedules lots of 'onBrokerReady' events which triggers nodes memory leak warning. Give a higher threshold.
5) Even though Partitioner has no body, still added super ctor for correctness, so if a body is added in the future, bugs are prevented.
6) Clean up some code style to use named functions instead of anonymous functions for consistency, and use let/const in some places
7) Made notes about intentionally not calling KafkaClient and ConsumerGroup's ctors, although this is a sign of maintenance concerns as this will make it more difficult to rewrite to classes, and this should be resolved in the future.

* move super ctor down below self instantiating client

1080 of 1442 branches covered (74.9%)

3424 of 3902 relevant lines covered (87.75%)

103151.51 hits per line