zulip / zulip-mobile / 4781

65%

push

travis-ci

types: Add TimingItemType for timing diagnostics usage.

Timing operations inside the app consists of making calculations,
(elapsed time) on the start and end times of some operations.
That calculations use Date.now(), performance.now(), return 'number'.
So, we cannot simply give a 'Date' type without changing
the elapsed time (diff between two operations) logic.

Also delete the case in timing.end() that attempted to log something
when no corresponding timing.start() was called, where we tried
logging an ill-typed version of an item.  This would cause 'undefined'
behavior for 'item.start' in 'TimingScreen' for that log items which
don't have 'start' field.  Also 'duration' calculation in 'TimeItem'
is not very informative about the actual duration (we don't know the
start time).

[greg: Deleted that case following Gökcan's suggestion in original
 commit, and adjusted commit message to match.]

866 of 1927 branches covered (44.94%)

Branch coverage included in aggregate %.

1586 of 3229 relevant lines covered (49.12%)

28.36 hits per line