zulip / zulip-mobile / 4749

65%

push

travis-ci

Improve stability of navBar. (#2141)

* mainNavBar: Fix re-render on navigating back.

Use connectWithActionsPreserveOnBack instead
of connectWithActions so that it do not
re-render unnecessary on navigating back.

This can be tested easily on Android, little bit old device.

It fixes the momentary flash of white color (from stream color)
in nav bar on navigating back to main screen.

In private narrow, back arrow is not visible for some millisecond
in transaction back to main screen.

* modalNavBar: Fix re-render on navigating back.

Use connectWithActionsPreserveOnBack instead
of connectWithActions so that it do not
re-render unnecessary on navigating back.

This can be tested easily on Android, little bit old device.

In lightbox, it reduces re-render of header, when component
is about to unmount.

* modalSearchNavBar: Fix re-render on navigating back.

Use connectWithActionsPreserveOnBack instead
of connectWithActions so that it do not
re-render unnecessary on navigating back.

This can be tested easily on Android, little bit old device.

In search narrow, back arrow is not visible for some millisecond
in transaction back to main screen.

866 of 1922 branches covered (45.06%)

Branch coverage included in aggregate %.

1585 of 3223 relevant lines covered (49.18%)

28.41 hits per line