esl / MongooseIM / 4349

86%

push

travis-ci

<a href="https://github.com/esl/MongooseIM/commit/<a class=hub.com/esl/MongooseIM/commit/63aaf5101fc54065cb11095d28d515835082d6a2">63aaf5101<a href="https://github.com/esl/MongooseIM/commit/63aaf5101fc54065cb11095d28d515835082d6a2">&quot;&gt;Introduce &amp;#39;foreground&amp;#39; mode #1775

* Introduce &amp;#39;foreground&amp;#39; mode

In rebar the &amp;#39;foreground&amp;#39; mode is usually used when the erlang app is
running as a daemon within a supervising service such as systemd or
upstart. To work correctly within those services some flags for &amp;#39;erl&amp;#39;
are necessary so that for example unix pipelines can be used. This
patch introduces the &amp;#39;foreground&amp;#39; mode as known from rebar which is
very similar to live/console but sets the following additional flags:

    -noshell -noinput +Bd

Those are documented at:

    http://erlang.org/doc/man/erl.html

The very same flags are also used in relx and distillery:

https://github.com/bitwalker/distillery/blob/master/priv/libexec/commands/foreground.sh#L18
https://github.com/erlware/relx/blob/</a><a class="double-link" href="https://github.com/esl/MongooseIM/commit/<a class="double-link" href="https://github.com/esl/MongooseIM/commit/86d415f33c500d432d6c9fa2fcbff3bb2fff3e8f">86d415f33</a>">86d415f33</a><a href="https://github.com/esl/MongooseIM/commit/63aaf5101fc54065cb11095d28d515835082d6a2">/priv/templates/extended_bin#L623

It should definitely be thought about adjusting the systemd unit file so
that &#39;foreground&#39; is used instead of &#39;start&#39;. Otherwise the beam process
is not considered as main PID and when the beam is killed you are not
notified properly via the standard systemd tooling (e.g. &#39;systemctl
status&#39; returns 0).

* Add some basic documentation for &#39;foreground' mode

* Mention new 'foreground' mode in list of commands

20342 of 28676 relevant lines covered (70.94%)

12725.08 hits per line