pymc-devs / pymc3 / 7503

87%

push

travis-ci

Refactor distribution.draw_values (#2902)

* Fix for #2900. Changed the way in which draw_values handles the named node-inputs. Now the tree dependence is constructed to set the givens dict.

* Fixed conflicts

* Fixed more conflicts

* Fixed typo

* Changed test_dep_vars to test for successful draws even in the cases of dependent variables.

* Removed comments from test_random.py, and distribution.py. Added content to RELEASE-NOTES. Fixed bug in the interaction between draw_values, _draw_value and _compile_theano_function. In some cases, draw_values would set an item of the givens dictionary to a theano.tensor.TensorConstant. In _draw_value(param, ...), if param was a theano.tensor.TensorVariable without a random method, and not set in point, _compile_theano_function would be called, using as one of its variables, a theano.tensor.TensorConstant. This lead to TypeError: ("Constants not allowed in param list",...) exceptions being raised. The fix was to skip the inclusion into the givens dictionary of named nodes that were instances of theano.tensor.TensorConstant, because their value would already be available for theano during the function compilation.

* Fixed another bug which was similar to the theano.tensor.TensorConstant, but it occurred on theano.tensor.sharedvar.SharedVariable instances. The error that was raised was similar, SharedVariables cannot be supplied as raw input to theano.function. The fix was the same as for TensorConstants, skip them when constructing the givens dictionary.

* Guarded against a potencial bug. In draw_values, when skipping for TensorConstant and SharedVariable types, these nodes could be added to the stack again later because their names would not be in givens.keys(). To counter that, a separate set, `stored`, with the names of nodes that are either stored in givens or whos values should be available to theano.function, is used to chose which nodes to add to the stack.

* Syntax change based on twie... (continued)

68 of 68 new or added lines in 3 files covered. (100.0%)

16297 of 18492 relevant lines covered (88.13%)

4.76 hits per line