TryGhost / Ghost-Admin / 3559

70%

push

travis-ci

Prevent keymaster bindings from causing failed tests (#976)

no issue
- keymaster bindings could be kept around between tests with references to objects that should have been deleted. This was manifesting itself with a Tags acceptance test failing because one of the key binding tests triggered two actions, one on the route under test and another on a route that was kept around from a previous Error Handling acceptance test (previous test intentionally had an aborted transition so the action in the current test was complaining about the first transition not being complete)
- add guard to ensure that shortcuts can't be registered multiple times on an object
- remove all `default` scope keymaster bindings when destroying a test app instance

1779 of 2828 branches covered (62.91%)

4102 of 5700 relevant lines covered (71.96%)

44.17 hits per line