5230
46%

Ran 18 Mar 2018 07:10PM UTC

Jobs 1

Files 87

Run time 4s

Badge

Embed ▾

pending completion

Build # 5230

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Stop always requiring second_shirt for staff (#3171)

* Stop always requiring second_shirt for staff

If one's shirt size was marked, shirt_info_marked was only truthy if either the person in question wasn't staff or if their second_shirt was set -- this meant that for events without 2 shirts, staffers would never be able to move past the 'shirt' step. This fixes that by checking the event's config, much like the shirt template does.

* Only set second_shirt when appropriate

This adds an extra safety check for the shirt size step in the volunteer checklist. Now it only tries to set attendee.second_shirt if the event has more than one shirt per staffer, making it more like the template you submit the form from.

* Add shirt info tests for events without staff shirts

We were only testing shirt info marked for events with 3 staff shirts configured. This adds a new unit test that covers events with just 1 staff shirt to reflect the change to the shirt_info_marked property.

* Flake fix

I've been spoiled by PyCharm's editor.

Run Details

6238 of 12939 relevant lines covered (48.21%)

0.48 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	5230.2 (TOX_ENV=py34)	18 Mar 2018 07:10PM UTC	0	48.21	Travis Job 5230.2

Source Files on build 5230

Detailed source file information is not available for this build.

magfest / ubersystem / 5230
46%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5230

magfest / ubersystem / 5230 46%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5230

magfest / ubersystem / 5230
46%

README BADGES
x