• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

letsencrypt / boulder / 8862
66%

Build:
DEFAULT BRANCH: master
Ran 17 Mar 2018 01:19AM UTC
Jobs 1
Files 85
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
8862

cron

travis-ci

rolandshoemaker
Harmonize order expiry with assoc. authz expiry. (#3567)

Prior to this commit an order's expiry was set based on
ra.orderLiftime while pending and valid authorization expiry was set
based on ra.pendingAuthorizationLifetime and
ra.authorizationLifetime. Since orders reused existing valid/pending
authorizations this can lead to a case where an order has an expiry
beyond the associated authorization expiries. In this case when an
authorization expired the order becomes inactionable and the extra order
lifetime is not useful.

This commit addresses this problem in two ways:

1. The SA GetAuthorizations function used to find authzs to reuse for
ra.NewOrder is adjusted to only return authorizations at min 24hr
away from expiry.
2. Order expiry is now calculated by the RA in newOrder
as the min of the order's own expiry or the soonest
authorization expiry. This properly reflects the order's true
lifetime based on the authorization lifetime.

The RA/SA unit tests are updated accordingly.

Resolves #3498

9765 of 15727 relevant lines covered (62.09%)

0.69 hits per line

Jobs
ID Job ID Ran Files Coverage
6 8862.6 (RUN="coverage") 17 Mar 2018 01:19AM UTC 0
62.09
Travis Job 8862.6
Source Files on build 8862
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #8862
  • 21a17f0b on github
  • Prev Build on master (#8861)
  • Next Build on master (#8865)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc